View Issue Details

IDProjectCategoryView StatusLast Update
0001650K18X001.00 SKB SWANSWpublic2023-02-21 12:30
Reporter(ALTech) Sangmin Choi Assigned To(ALTech) Sangmin Choi Due Date2023-02-17 17:19
PrioritylowSeveritys4-minorReproducibilityN/A
Status closedResolutionfixed 
Summary0001650: The custom code of BRM-BT11 was wrong.
DescriptionThe custom code of BRM-BT11 was wrong.
SWAN has no definitions for "0xF3(remote), Version : 0xA0 ~ 0xA4".

// BFX-AT100
common/arch/arm64/boot/dts/amlogic/g12a_s905x2_eagle_3g.dts
// Vendor : BT07
// Vendor : 0xF4(movon), Version : 0x40 ~ 0x4A, Total : 11
                        REMOTE_KEY(0x40F4,704)
                        REMOTE_KEY(0x41F4,705)
                        REMOTE_KEY(0x42F4,706)
                        REMOTE_KEY(0x43F4,707)
                        REMOTE_KEY(0x44F4,708)
                        REMOTE_KEY(0x45F4,709)
                        REMOTE_KEY(0x46F4,710)
                        REMOTE_KEY(0x47F4,711)
                        REMOTE_KEY(0x48F4,712)
                        REMOTE_KEY(0x49F4,713)
                        REMOTE_KEY(0x4AF4,714)

// Vendor : BT11
// Vendor : 0xF3(remote), Version : 0xA0 ~ 0xA4, Total : 5
                        REMOTE_KEY(0xA0F3,694)
                        REMOTE_KEY(0xA1F3,695)
                        REMOTE_KEY(0xA2F3,696)
                        REMOTE_KEY(0xA3F3,697)
                        REMOTE_KEY(0xA4F3,698)

// BFX-UA300
syna-release/boot/bootloader/sm_rom/customization/bg5ct_ffv/include/sm_ir_key_table.h
        {0x40f3, MV_IR_KEY_CUSTOM143}, /* 0xF3(remote), BT07, Version : 0x40 ~ 0x4A, Total : 11 */
        {0x41f3, MV_IR_KEY_CUSTOM144},
        {0x42f3, MV_IR_KEY_CUSTOM145},
        {0x43f3, MV_IR_KEY_CUSTOM146},
        {0x44f3, MV_IR_KEY_CUSTOM147},
        {0x45f3, MV_IR_KEY_CUSTOM148},

        {0x46f3, MV_IR_KEY_CUSTOM149}, /* 0xF3(remote), BT11, Version : 0xA0 ~ 0xA4, Total : 5 */
        {0x47f3, MV_IR_KEY_CUSTOM150},
        {0x48f3, MV_IR_KEY_CUSTOM151},
        {0x49f3, MV_IR_KEY_CUSTOM152},
        {0x4af3, MV_IR_KEY_CUSTOM153},
Additional Informationhttps://jira.skbroadband.com/browse/BPM-14727
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (SW) Jason Ling , (SW) Jim Chen

Activities

(ALTech) Sangmin Choi

2023-02-16 10:08

developer   ~0012190

1.
modify the comment for BT11.
0x46f3 ~ 0x4af3 are not the custom code for BT11.

        {0x45f3, MV_IR_KEY_CUSTOM148},
-
- {0x46f3, MV_IR_KEY_CUSTOM149}, /* 0xF3(remote), BT11, Version : 0xA0 ~ 0xA4, Total : 5 */
+ {0x46f3, MV_IR_KEY_CUSTOM149},
        {0x47f3, MV_IR_KEY_CUSTOM150},

2.
Add correct custom codes for BT11.
You can refer to the Eagle's code, of course, you should convert to SWAN's shape.

// Vendor : BT11
// Vendor : 0xF3(remote), Version : 0xA0 ~ 0xA4, Total : 5
                        REMOTE_KEY(0xA0F3,694)
                        REMOTE_KEY(0xA1F3,695)
                        REMOTE_KEY(0xA2F3,696)
                        REMOTE_KEY(0xA3F3,697)
                        REMOTE_KEY(0xA4F3,698)

Thank you.

(SW) Dean Chiang

2023-02-16 17:14

developer   ~0012207

Hi Sangmin,

I check eagle dts and find some doubts.
BT7 and BT11 have the same key.(see pic)
common/arch/arm64/boot/dts/amlogic/(g12a_s905x2_eagle_3g.dts

And I check kl file mark the bt7 key(see pic)
device/amlogic/common/products/eagle/Aml_keypad.kl

So I think swan have the same behavior of eagle but eagle forget to delete it.
Could you help to check it?

Thank you,
Dean Chiang
image.png (75,000 bytes)   
image.png (75,000 bytes)   
image-2.png (10,952 bytes)   
image-2.png (10,952 bytes)   

(ALTech) Sangmin Choi

2023-02-17 09:03

developer   ~0012218

Hi, Dean,

You're right, I found the latest document for RCU.
Please ignore my first comment(#c12190)

1.
Eagle didn't delete the IR codes for BT07(movon, remote, uei)

// Vendor : BT07
// Vendor : 0xF3(remote), Version : 0x40 ~ 0x4A, Total : 11
                        REMOTE_KEY(0x40F3,688)
                        REMOTE_KEY(0x41F3,689)
                        REMOTE_KEY(0x42F3,690)
                        REMOTE_KEY(0x43F3,691)
                        REMOTE_KEY(0x44F3,692)
                        REMOTE_KEY(0x45F3,693)
                        REMOTE_KEY(0x46F3,694) // should be removed
                        REMOTE_KEY(0x47F3,695) // should be removed
                        REMOTE_KEY(0x48F3,696) // should be removed
                        REMOTE_KEY(0x49F3,697) // should be removed
                        REMOTE_KEY(0x4AF3,698) // should be removed

// Vendor : BT07
// Vendor : 0xF4(movon), Version : 0x40 ~ 0x4A, Total : 11
                        REMOTE_KEY(0x40F4,704)
                        REMOTE_KEY(0x41F4,705)
                        REMOTE_KEY(0x42F4,706)
                        REMOTE_KEY(0x43F4,707)
                        REMOTE_KEY(0x44F4,708)
                        REMOTE_KEY(0x45F4,709)
                        REMOTE_KEY(0x46F4,710) // should be removed
                        REMOTE_KEY(0x47F4,711) // should be removed
                        REMOTE_KEY(0x48F4,712) // should be removed
                        REMOTE_KEY(0x49F4,713) // should be removed
                        REMOTE_KEY(0x4AF4,714) // should be removed

// Vendor : BT07
// Vendor : 0xF5(UEI), Version : 0x40 ~ 0x4A, Total : 11
                        REMOTE_KEY(0x40F5,720)
                        REMOTE_KEY(0x41F5,721)
                        REMOTE_KEY(0x42F5,722)
                        REMOTE_KEY(0x43F5,723)
                        REMOTE_KEY(0x44F5,724)
                        REMOTE_KEY(0x45F5,725) // should be removed
                        REMOTE_KEY(0x46F5,726) // should be removed
                        REMOTE_KEY(0x47F5,727) // should be removed
                        REMOTE_KEY(0x48F5,728) // should be removed
                        REMOTE_KEY(0x49F5,729) // should be removed
                        REMOTE_KEY(0x4AF5,730)

2.
SWAN didn't delete the IR codes for BT07(uei)

        {0x40f5, MV_IR_KEY_CUSTOM165}, /* 0xF5(UEI), BT07, Version : 0x40 ~ 0x4A, Total : 11 */
        {0x41f5, MV_IR_KEY_CUSTOM166},
        {0x42f5, MV_IR_KEY_CUSTOM167},
        {0x43f5, MV_IR_KEY_CUSTOM168},
        {0x44f5, MV_IR_KEY_CUSTOM169},
        {0x45f5, MV_IR_KEY_CUSTOM170}, // should be removed
        {0x46f5, MV_IR_KEY_CUSTOM171}, // should be removed
        {0x47f5, MV_IR_KEY_CUSTOM172}, // should be removed
        {0x48f5, MV_IR_KEY_CUSTOM173}, // should be removed
        {0x49f5, MV_IR_KEY_CUSTOM174}, // should be removed
        {0x4af5, MV_IR_KEY_CUSTOM175},

3.
SWAN defined wrong IR codes for BT11(remote)
Please modify as follows.

- {0x46f3, MV_IR_KEY_CUSTOM149}, /* 0xF3(remote), BT11, Version : 0xA0 ~ 0xA4, Total : 5 */
+ {0xa0f3, MV_IR_KEY_CUSTOM149}, /* 0xF3(remote), BT11, Version : 0xA0 ~ 0xA4, Total : 5 */
- {0x47f3, MV_IR_KEY_CUSTOM150},
+ {0xa1f3, MV_IR_KEY_CUSTOM150},
- {0x48f3, MV_IR_KEY_CUSTOM151},
+ {0xa2f3, MV_IR_KEY_CUSTOM151},
- {0x49f3, MV_IR_KEY_CUSTOM152},
+ {0xa3f3, MV_IR_KEY_CUSTOM152},
- {0x4af3, MV_IR_KEY_CUSTOM153},
+ {0xa4f3, MV_IR_KEY_CUSTOM153},

Thank you.
Sangmin Choi

(SW) Dean Chiang

2023-02-17 13:55

developer   ~0012229

Hi Sangmin,

SWAN modify done.
commit eeb69f39f182589ac4613a7fd27492bc42ae1b0c

Thank you.
Dean Chiang

Issue History

Date Modified Username Field Change
2023-02-13 16:24 (ALTech) Sangmin Choi New Issue
2023-02-13 16:24 (ALTech) Sangmin Choi Status new => assigned
2023-02-13 16:24 (ALTech) Sangmin Choi Assigned To => (SW) Jacky Chiang
2023-02-13 16:25 (ALTech) Sangmin Choi Issue Monitored: (SW) Jim Chen
2023-02-16 10:08 (ALTech) Sangmin Choi Note Added: 0012190
2023-02-16 10:24 (SW) Jason Ling Issue Monitored: (SW) Jason Ling
2023-02-16 10:24 (SW) Jason Ling Assigned To (SW) Jacky Chiang => (SW) Dean Chiang
2023-02-16 17:14 (SW) Dean Chiang Note Added: 0012207
2023-02-16 17:14 (SW) Dean Chiang File Added: image.png
2023-02-16 17:14 (SW) Dean Chiang File Added: image-2.png
2023-02-17 09:03 (ALTech) Sangmin Choi Note Added: 0012218
2023-02-17 13:55 (SW) Dean Chiang Note Added: 0012229
2023-02-18 11:30 (SW) Dean Chiang Assigned To (SW) Dean Chiang => (ALTech) Sangmin Choi
2023-02-21 12:30 (ALTech) Sangmin Choi Status assigned => closed
2023-02-21 12:30 (ALTech) Sangmin Choi Resolution open => fixed